[asterisk-bugs] [Asterisk 0011045]: compiling with MTX_PROFILE broken

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11045 
====================================================================== 
Reported By:                snuffy
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   11045
Category:                   Core/*
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 86572 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-21-2007 21:45 CDT
Last Modified:              10-25-2007 11:09 CDT
====================================================================== 
Summary:                    compiling with MTX_PROFILE broken
Description: 
   [CC] ast_expr2.c -> ast_expr2.o
In file included from
/home/bradl/asterisk-latest/include/asterisk/linkedlists.h:23,
                 from
/home/bradl/asterisk-latest/include/asterisk/frame.h:37,
                 from
/home/bradl/asterisk-latest/include/asterisk/channel.h:146,
                 from
/home/bradl/asterisk-latest/include/asterisk/pbx.h:27,
                 from ../main/ast_expr2.y:202:
/home/bradl/asterisk-latest/include/asterisk/lock.h: In function
`__ast_pthread_mutex_lock':
/home/bradl/asterisk-latest/include/asterisk/lock.h:318: error: `mtx_prof'
undeclared (first use in this function)
/home/bradl/asterisk-latest/include/asterisk/lock.h:318: error: (Each
undeclared identifier is reported only once
/home/bradl/asterisk-latest/include/asterisk/lock.h:318: error: for each
function it appears in.)
make[1]: *** [ast_expr2.o] Error 1
make: *** [utils] Error 2

====================================================================== 

---------------------------------------------------------------------- 
 murf - 10-25-07 11:09  
---------------------------------------------------------------------- 
OK, I see why this faked everyone out! The problem is, that ast_expr2.c is
generated by bison from ast_expr2.y. NEVER change the .c file, because
your
changes will be lost, when someone makes a change and regenerates
ast_expr2.c.

So, change the .y file instead, and then follow the rules in the 
Makefile to generate the .c, which has to be done by hand, then 
commit them BOTH to svn, so users out there don't have to try using bison
themselves. Oh, and make sure you are using the correct version of bison,
or disaster will result.

There were 2 files in trunk that needed this fix; so I'll use the commit
template to close this bug here in a second. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-25-07 11:09  murf           Note Added: 0072506                          
======================================================================