[asterisk-bugs] [Zaptel 0010950]: Provide make rpm functionality to Zaptel

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10950 
====================================================================== 
Reported By:                cabal95
Assigned To:                qwell
====================================================================== 
Project:                    Zaptel
Issue ID:                   10950
Category:                   NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Zaptel Version:             1.4.5.1  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-11-2007 13:05 CDT
Last Modified:              10-18-2007 14:40 CDT
====================================================================== 
Summary:                    Provide make rpm functionality to Zaptel
Description: 
This patch provides the make rpm functionality to Zaptel, similiar to the
Linux Kernel method of building rpms. The patch has been tested on FC6 but
should probably receive more testing on various platforms before entering
svn.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0010951 Provides(fix) make rpm functionality to...
====================================================================== 

---------------------------------------------------------------------- 
 cabal95 - 10-18-07 14:40  
---------------------------------------------------------------------- 
To a degree, yes.  Obviously sitting there and running make rpm over and
over should produce the same binaries, but version 1.4.10.1 might be
different than 1.4.10.2 because I decided to add in some modules and
re-'make rpm'.  Ideally the only thing it should depend on in terms of
changing functionality is the results of your 'make menuselect' and
possibly ./configure.

I would expect that if digium, fedora, yellowdog, etc. were to ever
prepare "standard custom" rpms then they should also follow the linux
kernel model.  I.e. my fedora core 6 kernels all have .fc6 somewhere in the
version.  Perhaps we could do something like the following to differentiate
between a "stock" build and a custom build:

'make dist-rpm' -> zaptel-1.4.5-1.rpm
make rpm -> zaptel-1.4.5-1.local.rpm
make rpm DISTRO='fc6' -> zaptel-1.4.5-1.fc6.rpm

If DISTRO is not defined then we would use "local" (maybe use `hostname
-s` or something), otherwise use it as given as part of the release build
number.  make dist-rpm could just map to 'make rpm DISTRO=""'

Your "stock" rpm would always have the same functionality for a given
version number, and any custom built rpms would have a tag in the
version/revision showing that they are not stock and "user beware" that
they should check the README.functionality file (hmm, could that be
generated on the fly from Makefile.menuselect?) that describes what
functionality is included in the rpm.

I do agree with you that either 1) make rpm should always provide the same
functionality or 2) (reading between the lines a bit) the version number
should be modified to show that number 1 may not be true. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-18-07 14:40  cabal95        Note Added: 0072249                          
======================================================================