[asterisk-bugs] [Asterisk 0010524]: res_features CLI revamping and removal of default builtins

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10524 
====================================================================== 
Reported By:                caio1982
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10524
Category:                   Resources/res_features
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 80129 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-22-2007 07:36 CDT
Last Modified:              10-16-2007 17:48 CDT
====================================================================== 
Summary:                    res_features CLI revamping and removal of default
builtins
Description: 
One problem already talked in previous reports about res_features
(regarding park-dial context) is that wasn't possible to avoid default
builtins for transfers and some parking options, even if you erase your
features.conf. There were hardcoded stuff in res_features.c

I changed it so it's now possible to have a clean installation where
nobody will ever use those default builtins to possible bypass the PBX
restrictions (my own case). Also, I've changed the way information are
displayed in the CLI so now it has a bunch of new parameters shown.

Random thoughts:

1. Having default builtins are wrong because the system may break its own
PBX restrictions

2. And even putting blank options in features.conf to null the builtins is
not very smart, IMHO. It's better have a way to configure them, I mean, at
least the major parameters.

3. Some key information such as timeouts were not getting shown.

4. Also, I have changed the default value for
DEFAULT_FEATURE_DIGIT_TIMEOUT from 500ms to 1000ms so it waits enough. It
was really a short ammount of time to press something in a softphone
keypad, for example.

5. I got rid of the middle column 'Default' in CLI's features show.
====================================================================== 

---------------------------------------------------------------------- 
 russell - 10-16-07 17:48  
---------------------------------------------------------------------- 
First off, thank you very much for the patch.  :)  Here is my opinion on
the changes:

1) I do not like the idea of removing the defaults.  It will break many
systems, and I don't feel it really provides any benefit.  There really
aren't any access control issues because:

  - For transfers, you have to explicitly allow them using the tT options
to Dial(), so there is no way that it is going to just magically work "by
default".

  - For call parking, you have to configure the dialplan in such a way
that parking is allowed, so again, it's not possible by any defaults.

2) I do like the CLI updates to show additional information.

3) I also agree that 500ms is too short.  1000ms is more reasonable. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-16-07 17:48  russell        Note Added: 0072130                          
======================================================================