[asterisk-bugs] [Asterisk 0010989]: Add fractional timeouts and default timeout variable values to Read

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10989 
====================================================================== 
Reported By:                michael-fig
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10989
Category:                   Applications/app_read
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.12.1  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-15-2007 20:47 CDT
Last Modified:              10-15-2007 21:25 CDT
====================================================================== 
Summary:                    Add fractional timeouts and default timeout variable
values to Read
Description: 
The Read application currently has no way to distinguish between when the
user pressed '#' (the variable is set to a zero-length string), or if the
Read application times out.

The attached patch adds a new option 'd' to Read that allows the dial plan
to set the variable, and leave its value unchanged on timeout.

The fractional read timeout is used to allow playing a single message
while polling for a key, then immediately advancing to a second message. 
This is useful when the messages are built out of fragments instead of one
big message that can be provided as the second argument to Read.
====================================================================== 

---------------------------------------------------------------------- 
 michael-fig - 10-15-07 21:25  
---------------------------------------------------------------------- 
When reviewing the patch, I noticed a few errors.  The first is that a
too-small timeout (less than 1ms) will result in the default being used.

Second, a defaultvalue variable that's larger than the tmp array will not
be properly zero-terminated.

The attached patch fixes these problems, and while I was at it, updates
the patch for asterisk-1.4.13. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-15-07 21:25  michael-fig    Note Added: 0072063                          
======================================================================