[asterisk-bugs] [Asterisk 0010970]: Remote console command completion is broken

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=10970 
====================================================================== 
Reported By:                jamesgolovich
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10970
Category:                   Core-General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 85534 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-13-2007 17:49 CDT
Last Modified:              10-15-2007 08:24 CDT
====================================================================== 
Summary:                    Remote console command completion is broken
Description: 
With the recent patch to move everything to NEW_CLI all of the builtin
commands aren't working (anything starting with _command).

I'm not really sure what the rational for having it setup this way is, but
just to see if it would work I moved the commands from builtins[] to
cli_cli[] and they all work after that.

In the code theres a comment for the builtins[] array stating:
/* XXX Nothing in this array can currently be deprecated...
   You have to change the way find_cli works in order to remove this
array
   I recommend doing this eventually...
I removed all references to builtins and just moving those NEW_CLIs over
to cli_cli seems to take care of everything.  I can come up with a patch to
do this, but there might be something I'm missing as to why we still need
the builtins array
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0010975 CLI autocompletion stopped working
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 10-15-07 08:24  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 85550

U   trunk/main/cli.c

------------------------------------------------------------------------
r85550 | russell | 2007-10-15 08:24:10 -0500 (Mon, 15 Oct 2007) | 9 lines

Move the CLI commands that were in builtins[] into the cli_cli[] array of
CLI
commands and remove the cli_iterator struct.  This gets tab completion
working
again.

(closes issue http://bugs.digium.com/view.php?id=10970)
Reported by: jamesgolovich
Patches: 
      asterisk-clicomplete.diff.txt uploaded by jamesgolovich (license
176)

------------------------------------------------------------------------ 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-15-07 08:24  svnbot         Checkin                                      
10-15-07 08:24  svnbot         Note Added: 0071973                          
10-15-07 08:24  svnbot         Status                   new => assigned     
10-15-07 08:24  svnbot         Assigned To               => russell         
======================================================================