[asterisk-bugs] [Asterisk 0010970]: Remote console command completion is broken

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10970 
====================================================================== 
Reported By:                jamesgolovich
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10970
Category:                   Core-General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 85534 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-13-2007 17:49 CDT
Last Modified:              10-14-2007 02:04 CDT
====================================================================== 
Summary:                    Remote console command completion is broken
Description: 
With the recent patch to move everything to NEW_CLI all of the builtin
commands aren't working (anything starting with _command).

I'm not really sure what the rational for having it setup this way is, but
just to see if it would work I moved the commands from builtins[] to
cli_cli[] and they all work after that.

In the code theres a comment for the builtins[] array stating:
/* XXX Nothing in this array can currently be deprecated...
   You have to change the way find_cli works in order to remove this
array
   I recommend doing this eventually...
I removed all references to builtins and just moving those NEW_CLIs over
to cli_cli seems to take care of everything.  I can come up with a patch to
do this, but there might be something I'm missing as to why we still need
the builtins array
====================================================================== 

---------------------------------------------------------------------- 
 jamesgolovich - 10-14-07 02:04  
---------------------------------------------------------------------- 
I just uploaded a patch that resolves this issue.  This essentialy gets rid
of the cli_iterator struct and the builtins array since I can't see any
reason for them to exist anymore.

I'm sure this could be fixed another way, but it seems like the
cli_iterator struct was just there to bridge the gap to what we have now. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-14-07 02:04  jamesgolovich  Note Added: 0071929                          
======================================================================