[asterisk-bugs] [Asterisk 0010938]: make config does not honor DESTDIR

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10938 
====================================================================== 
Reported By:                cabal95
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10938
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.12.1  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-10-2007 15:03 CDT
Last Modified:              10-11-2007 16:51 CDT
====================================================================== 
Summary:                    make config does not honor DESTDIR
Description: 
When doing a make DESTDIR=xxx config, the config rule does not honor the
DESTDIR variable.  Attached patch file to fix.  Patched against 1.4.13
(Cannot select that version yet).
====================================================================== 

---------------------------------------------------------------------- 
 cabal95 - 10-11-07 16:51  
---------------------------------------------------------------------- 
Do you mean does it work correctly if DESTDIR is an absolute path?  No, it
doesn't.  This patch is essentially two things.

1) the $(INSTALL) command is run without $(DESTDIR) so anytime you 'make
config' it always goes into the system /etc path instead of $(DESTDIR). 
This part shouldn't matter wether DESTDIR is absolute or relative.

2) The chkconfig / rc-update command is always run. For sure when we build
an RPM we don't want that to happen.  I would think if $(DESTDIR) is set
then we don't want to run those commands as they will probably error out
since the files are not in the correct place.

Neither of these issues should be determined by $(DESTDIR) being absolute
or relative. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-11-07 16:51  cabal95        Note Added: 0071843                          
======================================================================