[asterisk-bugs] [Zaptel 0010950]: Provide make rpm functionality to Zaptel

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10950 
====================================================================== 
Reported By:                cabal95
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   10950
Category:                   NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Zaptel Version:             1.4.5.1  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-11-2007 13:05 CDT
Last Modified:              10-11-2007 16:12 CDT
====================================================================== 
Summary:                    Provide make rpm functionality to Zaptel
Description: 
This patch provides the make rpm functionality to Zaptel, similiar to the
Linux Kernel method of building rpms. The patch has been tested on FC6 but
should probably receive more testing on various platforms before entering
svn.
====================================================================== 

---------------------------------------------------------------------- 
 tzafrir - 10-11-07 16:12  
---------------------------------------------------------------------- 
Thanks very much for your patch.

A few comments:

1. What should be the version of svn builds?

2. You should use KVERS rather than KVERSION to set the kernel source
version string.
Providing a hook to set KSRC should also be useful, I guess.

3. I would avoid the "install-modconf" target: it's buggy. It was created
to remove a buggy functionality from the default install target.

4. The doc includes README.fxsusb, but not README, nor xpp/REAME.Astribank
.

5. The Makefile patch includes some changes that are already merged into
the SVN version. Could you test your patch with the SVN version?

6. zaptel.spec: build_tools/mkspec FORCE
There must be a smarter way.

7. the rpm target runs a 'clean' (but not 'dist-clean'). This implies a
very non-reproducable build. The way I see it: either package binary
products (from 'make install DESTDIR=$PWD/target) or package a
newely-opened tarball with a few explicit additions.

8. The scriptlet used for the spec file building in the rpm: target should
be moved to a separate script, as it is complicate to debug as-is (you
can't add comments. You can't re-out parts of it, errors refer to cryptic
line numbers, etc). 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-11-07 16:12  tzafrir        Note Added: 0071840                          
======================================================================