[asterisk-bugs] [Asterisk 0010945]: [patch] delete non-existant schedule

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=10945 
====================================================================== 
Reported By:                flefoll
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   10945
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 85280 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-11-2007 01:29 CDT
Last Modified:              10-11-2007 10:05 CDT
====================================================================== 
Summary:                    [patch] delete non-existant schedule
Description: 
chan_sip revision 79857 introduced several schedule cancelations before new
schedule activations (SIP timeouts handling).

One of them seems useless in __sip_reliable_xmit() : the packet structure
has just been allocated, so there can't be any schedule already activated
(plus : the test is "retransid > -1" while the whole packet structure was
'memset' to 0).

I propose a patch to remove this call to ast_sched_del().

====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 10-11-07 10:05  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 85397

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r85397 | file | 2007-10-11 10:05:45 -0500 (Thu, 11 Oct 2007) | 6 lines

When creating a new packet don't try to stop retransmission of it. It was
just allocated/created so it's impossible for it to have already been
scheduled.
(closes issue http://bugs.digium.com/view.php?id=10945)
Reported by: flefoll
Patches:
      chan_sip.c.br14.85280.xmit_reliable-patch uploaded by flefoll
(license 244)

------------------------------------------------------------------------ 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-11-07 10:05  svnbot         Checkin                                      
10-11-07 10:05  svnbot         Note Added: 0071815                          
10-11-07 10:05  svnbot         Status                   new => assigned     
10-11-07 10:05  svnbot         Assigned To               => file            
======================================================================