[asterisk-bugs] [Asterisk 0010894]: pulsedial=no setting is runtime changed in chan_zap.c so you can't simply disable pulse dialling

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10894 
====================================================================== 
Reported By:                arekm
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10894
Category:                   Channels/chan_zap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.11  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-05-2007 01:34 CDT
Last Modified:              10-06-2007 04:10 CDT
====================================================================== 
Summary:                    pulsedial=no setting is runtime changed in
chan_zap.c so you can't simply disable pulse dialling
Description: 
The problem is that pulsedial=no setting is ignored in zapata.conf. If
pulse dialing is detected on the zap channel then chan_zap automaticly
changes pulsedial to yes runtime.

The pulsedial option should be IMO changed to some tristate value:
yes/no/auto to obey administrator whishes.

Relevant channels/chan_zap.c code:

        ast_log(LOG_DEBUG, "Got event %s(%d) on channel %d (index %d)\n",
event2str(res), res, p->channel, index);

        if (res & (ZT_EVENT_PULSEDIGIT | ZT_EVENT_DTMFUP)) {
                p->pulsedial =  (res & ZT_EVENT_PULSEDIGIT) ? 1 : 0;

                ast_log(LOG_DEBUG, "Detected %sdigit '%c'\n", p->pulsedial
? "pulse ": "", res & 0xff);

====================================================================== 

---------------------------------------------------------------------- 
 tzafrir - 10-06-07 04:10  
---------------------------------------------------------------------- 
The way I understand it, pulsedial is set from the user on FXO channels
(where we need to dial) and automatically detected on FXS channels (where
we detect digits).

In light of that, can you please be more specific in your bug description
as to what you consider is incorrect?

Could you please provide a test case? 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-06-07 04:10  tzafrir        Note Added: 0071580                          
======================================================================