[asterisk-bugs] [Asterisk 0010810]: [patch] Add optional sendtext (like sendurl is now)

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10810 
====================================================================== 
Reported By:                outtolunc
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10810
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 83126 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             09-23-2007 18:17 CDT
Last Modified:              10-02-2007 14:55 CDT
====================================================================== 
Summary:                    [patch]  Add optional sendtext (like sendurl is now)
Description: 
gives you the ability to sendtext to the 'called' party 
(if the channel supports it), just like sendurl does now.

example:  exten => 5,1,Dial(IAX2/outtolunc,,t,,hold his foot still!)


====================================================================== 

---------------------------------------------------------------------- 
 outtolunc - 10-02-07 14:55  
---------------------------------------------------------------------- 
i added DIAL_NOFORWARDTEXT in the same fashion as as the sendurl stuff

when i got to this section

  750         } else if (f->frametype == AST_FRAME_TEXT &&
!ast_test_flag64(outgoing, OPT_RINGBACK|OPT_MUSICBACK)) {
  751           if (ast_write(in, f))
  752             ast_log(LOG_WARNING, "Unable to send text\n");
  753         } else if (f->frametype == AST_FRAME_HTML &&
!ast_test_flag64(outgoing, DIAL_NOFORWARDHTML)) {
  754           if (ast_channel_sendhtml(in, f->subclass, f->data,
f->datalen) == -1)
  755             ast_log(LOG_WARNING, "Unable to send URL\n");

which the AST_FRAME_TEXT was the only TEXT code in app_dial, 
i figured it was a left over paste from a previous mod, and 
used sendhtml as a base. (the patch works on mine)

am i missing something obvious in why the OPT_RINGBACK|OPT_MUSICBACK was
on 
AST_FRAME_TEXT ? 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-02-07 14:55  outtolunc      Note Added: 0071353                          
======================================================================