[asterisk-bugs] [Asterisk 0009777]: [patch] Wrapuptime persistent in a multiple queues with shared members enviroment.

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=9777 
====================================================================== 
Reported By:                eliel
Assigned To:                bweschke
====================================================================== 
Project:                    Asterisk
Issue ID:                   9777
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 65499 
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             05-22-2007 13:28 CDT
Last Modified:              10-01-2007 08:36 CDT
====================================================================== 
Summary:                    [patch] Wrapuptime persistent in a multiple queues
with shared members enviroment.
Description: 
Suppose we have a member (tom) logged in more than one queue (queue1 and
queue2).
tom received a call from queue1 with wrapuptime (5 minutes).
This is because tom needs 5 minutes of work before receiving the next
call, but after a minute tom receives another call from queue2 because
queue2 knows nothing about queue1 wrapuptime (lastcall time). 
To solve this issue we implement a feature called shared_lastcall, and we
copy the lastcall timer to all the members (with the same interface) on the
other queues.
This can be enabled by configuration: 
queue.conf

[general]
shared_lastcall = yes|no

With this option enabled (not by default), queue2 will wait until queue1
wrapuptime expires.

====================================================================== 

---------------------------------------------------------------------- 
 eliel - 10-01-07 08:36  
---------------------------------------------------------------------- 
ping bweschke.
Please notice that ao2_find for members is using a case sensitive compare
and should be case insensitive (this is because sip/eliel is the same as
SIP/eliel), I think at least that minor change should be commited.


@@ -785,7 +790,7 @@
 static int member_cmp_fn(void *obj1, void *obj2, int flags)
 {
 	struct member *mem1 = obj1, *mem2 = obj2;
-	return strcmp(mem1->interface, mem2->interface) ? 0 : CMP_MATCH;
+	return strcasecmp(mem1->interface, mem2->interface) ? 0 : CMP_MATCH;
 }
 
 static void init_queue(struct call_queue *q) 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-01-07 08:36  eliel          Note Added: 0071229                          
======================================================================