[asterisk-bugs] [Zaptel 0008290]: [patch] zap hookstate is never set offhook if wctdm module is loaded with an active fxo line

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=8290 
====================================================================== 
Reported By:                tmarkov
Assigned To:                mattf
====================================================================== 
Project:                    Zaptel
Issue ID:                   8290
Category:                   wctdm
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Zaptel Version:              1.2.10 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             11-03-2006 17:28 CST
Last Modified:              11-29-2007 09:18 CST
====================================================================== 
Summary:                    [patch] zap hookstate is never set offhook if wctdm
module is loaded with an active fxo line
Description: 
If #define ZAP_CHECK_HOOKSTATE is uncommented in chan_zap.c, then the
hookstate stays onhook if the wctdm module is loaded with an active line. 
Removing line and reinserting will cause the hookstate to initialize
properly.  The problem appears to be that wc->mod[card].fxo.battery never
gets initialized to 0, so in wctdm_voicedaa_check_hook() the test "if
(!wc->mod[card].fxo.battery && !wc->mod[card].fxo.battdebounce)" is never
entered, and the hookstate remains onhook upon module startup.  Only a
cycling of line voltage will correct the problem.  I have attached a patch
which initializes the battery variable and fixes the problem for me.
====================================================================== 

---------------------------------------------------------------------- 
 flefoll - 11-29-07 09:18  
---------------------------------------------------------------------- 
I have ported my traces, meneault's patch, and mine on zaptel-1.4.7.
A "#define DBG8290" enables/(disables) traces.
Additionally,I have ported my patch to wctdm24xxp/base.c.
The new files, just for debugging at the moment, are :
- flf_zaptel-base.c-1.4.7-debugonly
- flf_wctdm.c-1.4.7-debugonly
- flf_wctdm24xxp/base.c-1.4.7-debugonly

It seems ok here, with two different hardware plaforms and TDM400P or
TDM2400P cards, even with meneault's patch disabled : different hardwares,
thus different timings ?

Feedback always welcome :-) 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-29-07 09:18  flefoll        Note Added: 0074545                          
======================================================================