[asterisk-bugs] [Asterisk 0011380]: having same voicemail pin as voicemail password should force user to change their password, but it does not

[noreply at bugs.digium.com]

The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=11380 
====================================================================== 
Reported By:                spditner
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   11380
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 89527 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             11-26-2007 13:17 CST
Last Modified:              11-26-2007 13:45 CST
====================================================================== 
Summary:                    having same voicemail pin as voicemail password
should force user to change their password, but it does not
Description: 
A matching voicemail extension and pin should not be allowed. Documentation
seems to indicate that matching ext/pin should cause app_voicemail to treat
them as a new user. However, it will presently only do so when the
FORCENAME, or FORCEGREETING options are set.

Looked at code, around line 6525:

6525    if (!strcasecmp(vmu->mailbox, vmu->password) &&                   
                                                                           
                               
6526       (ast_test_flag(vmu, VM_FORCENAME | VM_FORCEGREET))) {

The && should be ||

Tested and verified that it then behaved as expected.
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 11-26-07 13:45  
---------------------------------------------------------------------- 
No, it should be &&, and is correct.  There are two options in
voicemail.conf that must be set to have this behavior.  I believe they are
forcename and forcegreeting

Closing, as this is working as intended. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-26-07 13:45  qwell          Status                   new => resolved     
11-26-07 13:45  qwell          Resolution               open => fixed       
11-26-07 13:45  qwell          Assigned To               => qwell           
11-26-07 13:45  qwell          Note Added: 0074360                          
======================================================================