[asterisk-bugs] [Asterisk 0011294]: patch] find_context_locked() must return with conlock held

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11294 
====================================================================== 
Reported By:                ys
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   11294
Category:                   Core-General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 89408 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-19-2007 07:57 CST
Last Modified:              11-19-2007 18:17 CST
====================================================================== 
Summary:                    patch] find_context_locked() must return with
conlock held
Description: 

main/pbx.c: function find_context_locked() not neet to do
ast_unlock_contexts()


====================================================================== 

---------------------------------------------------------------------- 
 eliel - 11-19-07 18:17  
---------------------------------------------------------------------- 
I don't see why this should be changed, if the context isn't find you are
leaving the lock held more time than expected, and if the context is found
there is no logic improvement.
Your change makes the code more clean, but we are returning a NULL pointer
with a lock held in a structure that we will not use it.
BUT
If you think is better to cleanup the code, until commiting this patch you
should also update the function documentation. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-19-07 18:17  eliel          Note Added: 0074020                          
======================================================================