[asterisk-bugs] [Asterisk 0011263]: [patch] HOLD notification for Polycom phones

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11263 
====================================================================== 
Reported By:                russell
Assigned To:                oej
====================================================================== 
Project:                    Asterisk
Issue ID:                   11263
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.13  
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 89302 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-15-2007 13:55 CST
Last Modified:              11-18-2007 11:52 CST
====================================================================== 
Summary:                    [patch] HOLD notification for Polycom phones
Description: 
We added support for notifying HOLD status back when I was writing the SLA
code.  However, this only worked for some phones.  It never did work for
Polycom phones.  Polycom phones use the application/xpidf+xml format for
the XML format we send the state information in.

This change makes HOLD notification work for polycom phones.

However, this change will also slightly affect the format sent in
application/pidf+xml format.  According to a comment in the code, eyebeam
supports this format.  I'm not sure if hold notification worked with
eyebeam before, but I wanted to check to see if this patch had any effect
on that before committing.
====================================================================== 

---------------------------------------------------------------------- 
 oej - 11-18-07 11:52  
---------------------------------------------------------------------- 
I don't think "CLOSED" is the right thing to do. Isn't there any
documentation on the different states that Polycom supports? 

This format doesn't have any explicit hold states, so we just have to find
what works best for SIMPLE clients as well as the phones that try to show
something based on the SIMPLE states. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-18-07 11:52  oej            Note Added: 0073870                          
======================================================================