[asterisk-bugs] [Asterisk 0011228]: While working on T38 terminal support for asterisk

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11228 
====================================================================== 
Reported By:                Cache
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   11228
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 89214 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-13-2007 03:48 CST
Last Modified:              11-15-2007 05:32 CST
====================================================================== 
Summary:                    While working on T38 terminal support for asterisk
Description: 
While working on T38 terminal support for asterisk I discovered I can not
properly talk to Calweaver via UDPTL. It was strange because it seem like
their UDPTL implementation have common roots. I found that for some reason
two lines of udptl.c are commented out causing the problem. Attached patch
fixes the issue
====================================================================== 

---------------------------------------------------------------------- 
 dimas - 11-15-07 05:32  
---------------------------------------------------------------------- 
And actually, there is no "our" code. Basically, what was done:
1. uncommented several lines. I think they were commented out because when
udptl.c was initially added, ast_frame structure missed seqno field or
something - I think so because commented lines contained "???" before each
frame.seq_no reference
2. code common for "if" and "else" branches moved out of "if" just to save
space. Still, this code was already present in the file - it was just
moved. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-15-07 05:32  dimas          Note Added: 0073691                          
======================================================================