[asterisk-bugs] [Asterisk 0011228]: While working on T38 terminal support for asterisk

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11228 
====================================================================== 
Reported By:                Cache
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11228
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 89214 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-13-2007 03:48 CST
Last Modified:              11-13-2007 17:33 CST
====================================================================== 
Summary:                    While working on T38 terminal support for asterisk
Description: 
While working on T38 terminal support for asterisk I discovered I can not
properly talk to Calweaver via UDPTL. It was strange because it seem like
their UDPTL implementation have common roots. I found that for some reason
two lines of udptl.c are commented out causing the problem. Attached patch
fixes the issue
====================================================================== 

---------------------------------------------------------------------- 
 dimas - 11-13-07 17:33  
---------------------------------------------------------------------- 
I can't see Cache's patch until he disclaims it, but from a private chat
with him I assume he fixed line 372+392 in the udptl.c

Unfortunately it is not enough because this only fixes IFP sequence
numbering for "Secondary packet mode error recovery" and does not work in
FEC mode. Attached patch which fixes both cases and also does couple of
cleanups:
1. moves common code out of if/else
2. makes "Got UDPTL" messages be displayed exactly under same conditions
as "Sent UDPTL" to avoid confusion 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-13-07 17:33  dimas          Note Added: 0073614                          
======================================================================