[asterisk-bugs] [Zaptel 0011057]: Incorrect handling of international settings

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11057 
====================================================================== 
Reported By:                meneault
Assigned To:                mattf
====================================================================== 
Project:                    Zaptel
Issue ID:                   11057
Category:                   wcfxo
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 3211 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-23-2007 02:23 CDT
Last Modified:              11-08-2007 09:07 CST
====================================================================== 
Summary:                    Incorrect handling of international settings
Description: 
There is a simple error of hexadecimal/decimal in wcfxo.c which cause the
driver to ignore its international settings.
====================================================================== 

---------------------------------------------------------------------- 
 meneault - 11-08-07 09:07  
---------------------------------------------------------------------- 
As I have opened this bug with 'Incorrect handling of international
settings' I think it is the right place to add these new issues (if you
want me to open another bug, tell me).

Issue 3:
Even if international modes are now taken in account some settings are
still wrong, for TBR21 mode the ACT should be set to '1' (see si3034
specs).
However I let the CTR21 mode unchanged and added another one TBR21 (this
is original CTR21 mode with ACT set to 1).
Please see wcfxo-c_patch_mode_1_4_rev3121.

Issue 4:
Ring detection is also buggy, at the moment ring detection is done in
software mode and should detect [10,50] Hz rings but upper limit is too
low. Even a 50Hz ringer would hardly be detected with this. In France
ringer is 50Hz and ring is not detected by this detection routine just
because ringer isn't perfect.
So I added a patch to properly handle international ringers:
wcfxo-c_patch_ring_1_4_rev3121

Note: 
- you will probably get HUNK succeeded if you try to patch on a pristin
version of wcfxo.c because there is a specific order on these patches.
Perfect order would be:
 wcfxo-regs
 wcfxo-c_patch_ring_1_4_rev3121
 wcfxo-c_patch_mode_1_4_rev3121
However all these patches are all independent and can be applied
separately. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-08-07 09:07  meneault       Note Added: 0073387                          
======================================================================