[asterisk-bugs] [Asterisk 0010164]: Incorrect notify handling when hints contain multiple devices

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=10164 
====================================================================== 
Reported By:                nic_bellamy
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   10164
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            1.2.20  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             07-09-2007 21:48 CDT
Last Modified:              11-07-2007 19:27 CST
====================================================================== 
Summary:                    Incorrect notify handling when hints contain
multiple devices
Description: 
There's a logic flaw in transmit_state_notify():

When sending a state notification, the hints for the extension are checked
to see if the device is offline; if so it overrides the state notification
to say "not online".

The problem: if your hint contains multiple devices, _any_ of these being
offline will override the state. The state should only be overridden if
_all_ the hinted devices are offline.

This breaks BLFs for Polycom devices (and anything else using pidf/xpidf
notifications) when you have multiple devices hinted.

This was introduced by the fix for http://bugs.digium.com/view.php?id=9536.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 11-07-07 19:27  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 89099

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r89099 | file | 2007-11-07 19:26:59 -0600 (Wed, 07 Nov 2007) | 6 lines

Improve the devicestate logic for multiple devices. If any are available
then the extension is considered available.
(closes issue http://bugs.digium.com/view.php?id=10164)
Reported by: nic_bellamy
Patches:
      sip-hinting-svn-branch-1.4.patch uploaded by nic (license 299)

------------------------------------------------------------------------ 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-07-07 19:27  svnbot         Note Added: 0073349                          
11-07-07 19:27  svnbot         Status                   feedback => assigned
11-07-07 19:27  svnbot         Assigned To               => file            
======================================================================