[asterisk-bugs] [Asterisk 0008580]: [patch] Limit on simultaneous calls for queue members

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=8580 
====================================================================== 
Reported By:                rbraun_proformatique
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   8580
Category:                   Applications/General
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             12-13-2006 07:06 CST
Last Modified:              11-06-2007 17:15 CST
====================================================================== 
Summary:                    [patch] Limit on simultaneous calls for queue
members
Description: 
The queue application doesn't allow limits on simultaneous calls for queue
members. Some workarounds like call-limit in sip.conf cause many other
problems (for example, calls can't be transfered if call-limit is 1). We
(at Proformatique) have written a patch for app_queue which allows placing
such a limit. queues.conf can then be configured as this :

member = SIP/100[,penalty[,call-limit]]

If call-limit isn't specified, it is 0. A call-limit of 0 means no limit.
Thus, it shouldn't break any configuration (at least in the static conf
file, I haven't tested RealTime configurations).
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0007433 [branch] Devicestate not working correctly
related to          0006315 [patch] disable ringing on busy members...
====================================================================== 

---------------------------------------------------------------------- 
 Corydon76 - 11-06-07 17:15  
---------------------------------------------------------------------- 
1.  Please don't add credits to source files.  If you want a credit, add it
to the CREDITS file in the root directory.

2.  When adding new options to dialplan apps, please add them at the END
of the argument list.  Otherwise, you break backwards compatibility.  (APIs
are different, and rearrangement of those options is fine.)

3.  You are recycling the pausing.  It's clear that you're not using that,
but queue members who are using that will be very confused if they pause
themselves during a call (to take a bathroom break for instance) and are
immediately unpaused when the call ends.  Please consider that a bug that
needs to be fixed (i.e. you should only unpause a member, if their pausing
was caused by the call-limit).

4.  Again, messing with string order in the astdb breaks upgrades.  Always
add new options to the end.

5.  From a usability perspective, "call-limit" is difficult to type. 
Please consider renaming the CLI keyword "limit". 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-06-07 17:15  Corydon76      Note Added: 0073258                          
======================================================================