[asterisk-bugs] [Asterisk 0011159]: pbx_builtin_setvar_helper crash

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=11159 
====================================================================== 
Reported By:                850t
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   11159
Category:                   Addons/General
Reproducibility:            random
Severity:                   crash
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.13  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-05-2007 00:16 CST
Last Modified:              11-05-2007 16:07 CST
====================================================================== 
Summary:                    pbx_builtin_setvar_helper crash
Description: 
We have been experiencing a series of random crashes on our Asterisk
1.4.13.

We setup an asterisk server and it works completely fine for a month. 
Then we move the server to a higher loaded location with higher usage, and
queue, and voice recording, and more outgoing calls, then we experience
random crash.

Attached is the stack.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 11-05-07 16:07  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 88805

U   branches/1.4/include/asterisk/pbx.h
U   branches/1.4/main/pbx.c

------------------------------------------------------------------------
r88805 | russell | 2007-11-05 16:07:00 -0600 (Mon, 05 Nov 2007) | 12 lines

After seeing crashes related to channel variables, I went looking around
at the
ways that channel variables are handled.  In general, they were not
handled in
a thread-safe way.  The channel _must_ be locked when reading or writing
from/to
the channel variable list.

What I have done to improve this situation is to make
pbx_builtin_setvar_helper()
and friends lock the channel when doing their thing.  Asterisk API calls
almost 
all lock the channel for you as necessary, but this family of functions
did not.

(closes issue http://bugs.digium.com/view.php?id=10923, reported by atis)
(closes issue http://bugs.digium.com/view.php?id=11159, reported by 850t)

------------------------------------------------------------------------ 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-05-07 16:07  svnbot         Checkin                                      
11-05-07 16:07  svnbot         Note Added: 0073156                          
11-05-07 16:07  svnbot         Status                   feedback => assigned
11-05-07 16:07  svnbot         Assigned To               => russell         
======================================================================