[asterisk-bugs] [Asterisk 0010291]: Skinny to skinny calls one-way audio

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10291 
====================================================================== 
Reported By:                sbisker
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10291
Category:                   Channels/chan_skinny
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 76784 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-24-2007 11:13 CDT
Last Modified:              07-31-2007 20:28 CDT
====================================================================== 
Summary:                    Skinny to skinny calls one-way audio
Description: 
Version 76621 fixed the crashing of asterisk due to soft-key problems, but
introduced another problem.  

7921 -> 7921 phones the remote party could not hear any audio.  In version
76784, the 7921 that initiates the call hears no audio.  If a 7920 phone
calls a 7921/7920 phone, then both parties hear audio.
====================================================================== 

---------------------------------------------------------------------- 
 DEA - 07-31-07 20:28  
---------------------------------------------------------------------- 
Ignore my last message, it was a false trail.  I re-reviewed my CCM
captures
and noted a handful of things that we do different in chan_skinny (maybe
wrong).

In skinny_hangup() the transmit_tone() call needs to be before
transmit_callstate()

In transmit_callstate() we should move the code to setup and send the
call state to after the if..else block.  The end call on CCM looks like
this:

Transmit stop_tone
Transmit stop media
Transmit close receive channel
Transmit call state

Chan_skinny is doing this:
Transmit call state
Transmit stop media
Transmit close receive channel
Transmit stop tone

I can put together an incremental patch to apply on top of the
callstate-fixs
patch if you are not comfortable making the edits directly. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-31-07 20:28  DEA            Note Added: 0068177                          
======================================================================