[asterisk-bugs] [Asterisk 0010337]: 1.2 version of : 0008943: inUse counter not decremented after hanging up a call which is on hold

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10337 
====================================================================== 
Reported By:                cyber_monk
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10337
Category:                   Channels/chan_sip/Transfers
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     new
Asterisk Version:            1.2.23  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-30-2007 20:39 CDT
Last Modified:              07-31-2007 10:08 CDT
====================================================================== 
Summary:                    1.2 version of : 0008943: inUse counter not
decremented after hanging up a call which is on hold
Description: 
Issue 0008943 affecting asterisk 1.4 also happens in asterisk 1.2 starting
with release 1.2.16. 1.2.15 does not exhibit the block. 

When a sip call is put on hold the peer inuse count increments and never
gets decremented for the peer that placed the call on hold. Subsequently
any extensions that place calls on hold very quickly become unuseable !

This was discovered by a site that uses attended transfers heavily.


====================================================================== 

---------------------------------------------------------------------- 
 eliel - 07-31-07 10:08  
---------------------------------------------------------------------- 
Yes, you are right, I will upload a patch as soon as I can, but if you want
a simple solution try this:
on chan_sip.c on function update_call_counter() change:
- if (!outgoing && (u = find_user(name, 1))) {
with: 
+ if (0 && !outgoing && (u = find_user(name, 1))) {

With this patch all the limits will be update on the peer structure. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-31-07 10:08  eliel          Note Added: 0068121                          
======================================================================