[asterisk-bugs] [Asterisk 0010230]: [patch] where possible replace uses of channel->_softhangup with ast_check_hangup(channel)

[noreply at bugs.digium.com]

The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=10230 
====================================================================== 
Reported By:                juggie
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10230
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
Resolution:                 won't fix
Fixed in Version:           
====================================================================== 
Date Submitted:             07-18-2007 12:44 CDT
Last Modified:              07-30-2007 10:16 CDT
====================================================================== 
Summary:                    [patch] where possible replace uses of
channel->_softhangup with ast_check_hangup(channel)
Description: 
This is a step in the right direction but still doesn't remove many of the
cases where we access many _variables directaly outside where we should be.
====================================================================== 

---------------------------------------------------------------------- 
 russell - 07-30-07 10:16  
---------------------------------------------------------------------- 
After looking into this in more detail, I was mistaken on the usage of
ast_check_hangup.  It can not be used as a drop-in replacement for checking
the _softhangup variable.  You can schedule a channel to be hung up an hour
from now, which will cause this function to return true.  However,
applications that are running on the channel shouldn't care.  They only
need to know if it has already been hung up. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-30-07 10:16  russell        Note Added: 0068055                          
======================================================================