[asterisk-bugs] [Asterisk 0001719]: [patch] Caller ID support for UK (BT POTS lines)

[noreply at bugs.digium.com]

The following issue has been REOPENED. 
====================================================================== 
http://bugs.digium.com/view.php?id=1719 
====================================================================== 
Reported By:                TonyHoyle
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   1719
Category:                   Core/General
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.9 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-26-2004 10:13 CDT
Last Modified:              07-27-2007 14:05 CDT
====================================================================== 
Summary:                    [patch] Caller ID support for UK (BT POTS lines)
Description: 
This is an experimental patch to add caller id support for UK POTS lines.

The zaptel side of the patch just adds a 2 second rolling buffer that the
userspace driver can interrogate.  As the caller ID information in the UK
is sent before the first ring the CID burst will be there rather than
within the ring data itself as on the Bell system.

The asterisk side of the patch just adds v23 support to fskmodem and grabs
the saved buffer and passes it through the callerid state machine.  

Selection of the UK caller id format is currently by a 'ukcallerid=yes'
line.  This should probably be broadened out into a generic CID selection
for things like DTMF, etc.  

At the moment I'm just encouraging testing... it seems to work for me but
haven't had much feedback yet.

====================================================================== 

---------------------------------------------------------------------- 
 tzafrir - 07-27-07 14:05  
---------------------------------------------------------------------- 
I'd like to reopen this issue, as the patch for ukcid is still floating
around and maintained. It still seems to be useful for various people.

I was wondering if there is any way to merge the asterisk and Zaptel
patches without adding unnecessary runtime overhead. That is: on a system
with an X100P and another device ukcid support detection can be enabled at
runtime, but still not affect the performance of other Zaptel devices on
the same system.


1. The patch adds an extra definition in the userspace-visible parts of
zaptel.h, and hence the Asterisk parts should be safe to merge: the code is
only used for channels explicitly marked as cidstart=polarity".

Hence the extra code in the asterisk patch should be modified to use
#ifdef ZT_GET_HISTORY .

2. The code in the Zaptel patch is used for all Zaptel channels. Hence
there is unnecessary copying of the data to the history buffer. How can we
make this only happen for specific channels?

I see two general ways:

a. Give some sort of optional capability to the x100p driver, and thus
only x100p channels will have their history copied. Or:

b. Asterisk should ask Zaptel to copy history for specific channels
(another ioctl?) 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-27-07 14:05  tzafrir        Assigned To              markster =>         
07-27-07 14:05  tzafrir        Status                   closed => feedback  
07-27-07 14:05  tzafrir        Resolution               fixed => reopened   
07-27-07 14:05  tzafrir        Note Added: 0067993                          
======================================================================