[asterisk-bugs] [Asterisk 0010323]: [PATCH] Device state shows Hold after SIP native transfer

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=10323 
====================================================================== 
Reported By:                julianjm
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   10323
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 77489 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-27-2007 08:23 CDT
Last Modified:              07-27-2007 10:51 CDT
====================================================================== 
Summary:                    [PATCH] Device state shows Hold after SIP native
transfer
Description: 
The sip peer Hold status is updated twice after a native transfer. The
internal onHold variable for the sip peer is decremented twice (the second
time being in __sip_destroy()), thus always showing "State:Hold"
afterwards.

CLI> core show hints
                    205 at ext-local           : SIP/205              
State:Idle            Watchers  0
                    202 at ext-local           : SIP/202              
State:Idle            Watchers  0
                    201 at ext-local           : SIP/201              
State:Idle            Watchers  0


202 calls 201 (polycom 501), which blindly transfers to 205. The result:


CLI> core show hints
                    205 at ext-local           : SIP/205              
State:Idle            Watchers  0
                    202 at ext-local           : SIP/202              
State:Idle            Watchers  0
                    201 at ext-local           : SIP/201              
State:Hold            Watchers  0


This breaks BLF, but also affects FreePBX, because it uses the
ExtensionState manager action to check if a particular extension is Idle.

The attached patch clears the HOLD flag from the SIP channel as needed.
====================================================================== 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-27-07 10:51  file           Status                   new => assigned     
07-27-07 10:51  file           Assigned To               => file            
======================================================================