[asterisk-bugs] [Asterisk 0010297]: Unload/load support for chan_skinny

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10297 
====================================================================== 
Reported By:                DEA
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10297
Category:                   Channels/chan_skinny
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 76940 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-25-2007 01:40 CDT
Last Modified:              07-26-2007 15:18 CDT
====================================================================== 
Summary:                    Unload/load support for chan_skinny
Description: 
Reload is not working, but unload and load do work.
My reload code is ugly-simple, it calls the unload 
function, then the load function.  I would have thought
if I could manually unload and load that would be enough.


My threading knowledge is more than a bit weak, but the
existing code was 90% there already.  We needed to store
the address of the skinny_session thread launch from within
accept_thread so we could later cancel it.

Interestingly the skinnysession structure had a member to
store the thread address, but it did not appear to be used.

I also move the teardown of the accept thread to a point before
tearing down the sessions (and their threads) to prevent a phone
from trying to re-register and recreating a session thread after
we had processed it.


====================================================================== 

---------------------------------------------------------------------- 
 DEA - 07-26-07 15:18  
---------------------------------------------------------------------- 
I got distracted and did not get back to check that.

Perhaps on loading the channel it can try to locate existing
channels and re-attach to them.  But that will likely be ugly.

We do not want to hangup the channel, but do need a way to
detect orphaned channels.  It might work to queue a hangup
with already already gone set so that skinny_hangup does not
try to hangup the skinny channel, but I think that leave us
in the same spot.

Another option would be to traing the skinny_hangup callback to
acknowledge a hangup on a channel it does not know about.  That
way when the far end queues a hangup chan_skinny can signal that
it did hang it up... 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-26-07 15:18  DEA            Note Added: 0067944                          
======================================================================