[Asterisk-bugs] [Zaptel 0010244]: Allow modification of ZT_CHUNKSIZE

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10244 
====================================================================== 
Reported By:                UVSoft
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   10244
Category:                   General
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     new
Zaptel Version:              1.2.19  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-20-2007 02:37 CDT
Last Modified:              07-21-2007 17:21 CDT
====================================================================== 
Summary:                    Allow modification of ZT_CHUNKSIZE
Description: 
I've made a patch that makes ZT_CHUNKSIZE variable, thus someone can change
it to whatever he wants. It's very useful, e.g. I'm working on a driver for
some device and the device requires ZT_CHUNKSIZE to be much more, it's hard
for the device to operate with chunks of 8 samples, but 80 will do. The
problem is that there are some pieces of the code, where ZT_CHUNKSIZE is
implied to be 8, and if I just change ZT_CHUNKSIZE to 80, all the timeouts
will become crazy, the patch tries to fix this issue.
====================================================================== 

---------------------------------------------------------------------- 
 tzafrir - 07-21-07 17:21  
---------------------------------------------------------------------- 
The patch changes the default chunk size, and hence cannot be accepted
as-is.

Also: do you have a patch vs. zaptel trunk or zaptel 1.4?

Also:

#define ZT_CHUNKTIME		 (ZT_CHUNKSIZE / 8) /* 8kHz */

You still have a magic number 8 there. That 8 is actually the single
sample size, right? 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-21-07 17:21  tzafrir        Note Added: 0067700                          
======================================================================