[Asterisk-bugs] [Asterisk 0010164]: Incorrect notify handling when hints contain multiple devices

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10164 
====================================================================== 
Reported By:                nic_bellamy
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10164
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:            1.2.20  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             07-09-2007 21:48 CDT
Last Modified:              07-19-2007 15:58 CDT
====================================================================== 
Summary:                    Incorrect notify handling when hints contain
multiple devices
Description: 
There's a logic flaw in transmit_state_notify():

When sending a state notification, the hints for the extension are checked
to see if the device is offline; if so it overrides the state notification
to say "not online".

The problem: if your hint contains multiple devices, _any_ of these being
offline will override the state. The state should only be overridden if
_all_ the hinted devices are offline.

This breaks BLFs for Polycom devices (and anything else using pidf/xpidf
notifications) when you have multiple devices hinted.

This was introduced by the fix for http://bugs.digium.com/view.php?id=9536.
====================================================================== 

---------------------------------------------------------------------- 
 nic_bellamy - 07-19-07 15:58  
---------------------------------------------------------------------- 
Nearly there with the license - discussed it with KPF @ Digium and my
management, and there some actual changes in the v3.0 license that make
legal sense. Going through the process of getting it approved internally at
the moment. I was hoping to have it sorted in time to get the patch into
1.2.22, but that got fast tracked due to a number of security issues.

And yes, from reading the code, the bug does also affect 1.4 and trunk. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-19-07 15:58  nic_bellamy    Note Added: 0067609                          
======================================================================