[Asterisk-bugs] [Asterisk 0010237]: Incorrect handling of out of order full frames

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://www.example.com/var/www/insects.digium.com/core/view.php?id=10237 
====================================================================== 
Reported By:                mihai
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10237
Category:                   Channels/chan_iax2
Reproducibility:            random
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.8  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-19-2007 10:04 CDT
Last Modified:              07-19-2007 10:32 CDT
====================================================================== 
Summary:                    Incorrect handling of out of order full frames
Description: 
The code that handles full frames that arrive out of order does not take
into account the fact that sequence numbers are 8 bit values that wrap
around.  If there is a lost or duplicate frame around the time of a wrap
around, the server may send an erroneous VNAK or may not send a VNAK when
one is required.
In 1.4.8 release tarball, this happens in chan_iax2.c, on or around line
6717.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 07-19-07 10:32  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 75927

------------------------------------------------------------------------
r75927 | russell | 2007-07-19 10:32:42 -0500 (Thu, 19 Jul 2007) | 6 lines

When processing full frames, take sequence number wraparound into account
when
deciding whether or not we need to request retransmissions by sending a
VNAK.
This code could cause VNAKs to be sent erroneously in some cases, and to
not
be sent in other cases when it should have been.
(closes issue
http://www.example.com/var/www/insects.digium.com/core/view.php?id=10237,
reported and patched by mihai)

------------------------------------------------------------------------ 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-19-07 10:32  svnbot         Checkin                                      
07-19-07 10:32  svnbot         Note Added: 0067588                          
07-19-07 10:32  svnbot         Status                   new => assigned     
07-19-07 10:32  svnbot         Assigned To               => russell         
======================================================================