[Asterisk-bugs] [Asterisk 0010227]: Incorrect handling of VNAK retransmission
noreply at bugs.digium.com
noreply at bugs.digium.com
Wed Jul 18 15:45:13 CDT 2007
A NOTE has been added to this issue.
======================================================================
http://bugs.digium.com/view.php?id=10227
======================================================================
Reported By: mihai
Assigned To: russell
======================================================================
Project: Asterisk
Issue ID: 10227
Category: Channels/chan_iax2
Reproducibility: random
Severity: minor
Priority: normal
Status: assigned
Asterisk Version: 1.4.7.1
SVN Branch (only for SVN checkouts, not tarball releases): N/A
SVN Revision (number only!):
Disclaimer on File?: Yes
Request Review:
======================================================================
Date Submitted: 07-18-2007 09:49 CDT
Last Modified: 07-18-2007 15:45 CDT
======================================================================
Summary: Incorrect handling of VNAK retransmission
Description:
In vnak_retransmit you can find the following code:
if ((f->callno == callno) && iaxs[f->callno] &&
(f->oseqno >= last)) {
send_packet(f);
oseqno and last are 8-bit values that wrap around, so if a VNAK
retransmission is requested right after a wraparound, this code will behave
incorrectly.
Most probable effect would be that asterisk would not retransmitting the
right frames and the other endpoint would keep asking for them, generating
a VNAK storm
======================================================================
----------------------------------------------------------------------
russell - 07-18-07 15:45
----------------------------------------------------------------------
In the future, please put any code in attachments marked as code so that
they are automatically handled by our license system. In this case, I
think the change is small enough that's it's not a big deal.
I had to think about it for a few minutes, but I think that change looks
right. I'm going to commit that.
After that, should we use another issue to track remaining VNAK storm
problems?
Issue History
Date Modified Username Field Change
======================================================================
07-18-07 15:45 russell Note Added: 0067547
======================================================================
More information about the asterisk-bugs
mailing list