[Asterisk-bugs] [Asterisk 0010213]: rev71656 and rev71065 makes DeadAGI exit after channel hangup

[noreply at bugs.digium.com]

The following issue has been REOPENED. 
====================================================================== 
http://bugs.digium.com/view.php?id=10213 
====================================================================== 
Reported By:                lyl
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10213
Category:                   Resources/res_agi
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
Asterisk Version:            1.2.12.1  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             07-17-2007 03:39 CDT
Last Modified:              07-17-2007 22:11 CDT
====================================================================== 
Summary:                    rev71656 and rev71065 makes DeadAGI exit after
channel hangup
Description: 
   for Issue 10035, the developer fixed the "silly usages of
ast_playstream()", but another problem comes, there's no DeadAGI alive
after the channels hangup.

   the newest code follows:  (handle_exec in res_agi.c)

          return res >= 0 ? RESULT_SUCCESS : RESULT_FAILURE;
   
  but when the channel hangs up, the res is -1, and then return
2(RESULT_FAILURE), and, the result is the DeadAGI also dead.

the solution is, I think, return best cause just in ast_playstream, but
not in the caller code, it's not the duty of the caller to identify what's
happening in the calling code.

And, for issue 10035, maybe DeadAGI can solve the problem.  
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0010210 [patch] res_agi, some long outstanding ...
====================================================================== 

---------------------------------------------------------------------- 
 lyl - 07-17-07 22:11  
---------------------------------------------------------------------- 
Actually, The script is running stable in an v1.2.15 box, and when I
replace "return res >= 0 ? RESULT_SUCCESS : RESULT_FAILURE" with "return
res", the script works. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-17-07 22:11  lyl            Status                   closed => feedback  
07-17-07 22:11  lyl            Resolution               no change required =>
reopened
07-17-07 22:11  lyl            Note Added: 0067494                          
======================================================================