[Asterisk-bugs] [Asterisk 0010192]: New feature: Turn core debugging on for a file

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10192 
====================================================================== 
Reported By:                bbryant
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10192
Category:                   General
Reproducibility:            N/A
Severity:                   feature
Priority:                   none
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 74550 
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             07-12-2007 11:00 CDT
Last Modified:              07-17-2007 18:30 CDT
====================================================================== 
Summary:                    New feature: Turn core debugging on for a file
Description: 
This patch is helpful when debugging a single file for a problem.

I put it here so people could look it over and give their opinion.
====================================================================== 

---------------------------------------------------------------------- 
 russell - 07-17-07 18:30  
---------------------------------------------------------------------- 
1) I would like to see this same functionality added to core set verbose,
as well.

2) Here is my proposed syntax:

core set {debug|verbose} [atleast] <level> [filename]

3) For turning off debug for a file, I think my preferred behavior would
be to just have the existing "core set {debug|verbose} off".

4) As you pointed out when looking at this with me, you have a minor
memory leak in here when turning off debug.

5) I would also like to see you take advantage of an optimization for the
memory used for the filename with something like:

struct ast_debug_file {
   ...
   char filename[0];
}

struct ast_debug_file *df;

df = ast_calloc(1, sizeof(*df) + strlen(filename) + 1); 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-17-07 18:30  russell        Note Added: 0067490                          
======================================================================