[Asterisk-bugs] [Asterisk 0010200]: Users with the same last name are not all listed in the directory. Only one of them is.

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10200 
====================================================================== 
Reported By:                mrskippy
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   10200
Category:                   Applications/app_directory
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.5 
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        No 
Request Review:              
====================================================================== 
Date Submitted:             07-13-2007 10:05 CDT
Last Modified:              07-16-2007 09:14 CDT
====================================================================== 
Summary:                    Users with the same last name are not all listed in
the directory.  Only one of them is.
Description: 
The directory application does not support users with the same last name. 
Only one of these users gets listed.  I'm supprised that this has not been
dealt with already.

I did make sure the option "hasdirectory" is set to yes for both users. 
Both users are in the same context.  If I rename one of these users, he
shows up in the directory listing.
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 07-16-07 09:14  
---------------------------------------------------------------------- 
I agree that my first patch was not the best solution. I've made a new
patch and have uploaded it as directory_v2.patch.

I didn't just delete the two lines you suggested since we do want to break
out of the for loop if the user does not press *. Instead, I added a
conditional variable, breakout, which is used to test if we want to break
out of the for loop or not. Once again, I tested in my toy setup and it
works.

I also added an else to match the if(!strcmp(conv,ext)) since not always
breaking out of the for loop creates the possibility of freeing the same
variable twice. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-16-07 09:14  putnopvut      Note Added: 0067396                          
======================================================================