[Asterisk-bugs] [Asterisk 0010164]: Incorrect notify handling when hints contain multiple devices

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10164 
====================================================================== 
Reported By:                nic_bellamy
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10164
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:            1.2.20  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             07-09-2007 21:48 CDT
Last Modified:              07-10-2007 22:39 CDT
====================================================================== 
Summary:                    Incorrect notify handling when hints contain
multiple devices
Description: 
There's a logic flaw in transmit_state_notify():

When sending a state notification, the hints for the extension are checked
to see if the device is offline; if so it overrides the state notification
to say "not online".

The problem: if your hint contains multiple devices, _any_ of these being
offline will override the state. The state should only be overridden if
_all_ the hinted devices are offline.

This breaks BLFs for Polycom devices (and anything else using pidf/xpidf
notifications) when you have multiple devices hinted.

This was introduced by the fix for http://bugs.digium.com/view.php?id=9536.
====================================================================== 

---------------------------------------------------------------------- 
 nic_bellamy - 07-10-07 22:39  
---------------------------------------------------------------------- 
Hi Russell,

I am aware of the new system - and think it's a great idea for those who
don't already have a disclaimer - makes things easier for both sides.

I work for a company. As in most companies, we're not in the business of
giving extremely liberal (in favor of Digium) copyright licenses away for
free, so getting the original disclaimer done was quite an involved
process, involving CEO, legal, etc. This took me about two weeks to get
organized and signed-off on the first time around.

Suggesting I go through this entire process again is just ludicrous - I'm
trying to _give you code_! 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-10-07 22:39  nic_bellamy    Note Added: 0067094                          
======================================================================