[asterisk-bugs] [Asterisk 0011404]: SMDI MWI configuration on a per-user basis

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11404 
====================================================================== 
Reported By:                jaroth
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11404
Category:                   Applications/app_voicemail
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 90000 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-28-2007 13:10 CST
Last Modified:              12-27-2007 15:43 CST
====================================================================== 
Summary:                    SMDI MWI configuration on a per-user basis
Description: 
This patch provides the ability to use SMDI for MWI on a per-user basis. 
By adding the directive "usesmdi=yes" in a user's voicemail configuration,
that user can be notified via SMDI.  This is useful for mixed environments
where some users need SMDI notification and others do not.   This patch
also includes the ability to use a notification station number that is
different than the extension.  Currently the station is set to the user's
extension.  By adding the directive "smdistation=xxxx" to a user's
voicemail configuration, a different SMDI station can be tied to that user.
 This is also useful in mixed environments.
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 12-27-07 15:43  
---------------------------------------------------------------------- 
I have a couple of suggestions with regards to this patch:

1. Instead of making usesmdi a 4-byte buffer (presumably to store a value
like "yes"), make it an int and set it to ast_true() on the value that the
user set in voicemail.conf. That way you only have to call ast_true the one
time and can just check to see if usesmdi is non-zero in run_externnotify.
Another potential problem with the way it's implemented now is that if a
user sets "usemsdi=true", this will not have the desired effect since
ast_copy_string will only copy "tru" into usesmdi to account for the needed
null byte at the end.

2. Use ast_strlen_zero instead of checking if smdistation is not NULL. The
reason for this is that since smdistation is a statically sized character
buffer, it will never be NULL. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
12-27-07 15:43  putnopvut      Note Added: 0076065                          
======================================================================