[asterisk-bugs] [Asterisk 0009736]: [patch] "fixing" the saying of queue holdtime (for less than 2 minutes)

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=9736 
====================================================================== 
Reported By:                caio1982
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   9736
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 64186 
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             05-15-2007 21:38 CDT
Last Modified:              12-21-2007 20:57 CST
====================================================================== 
Summary:                    [patch] "fixing" the saying of queue holdtime (for
less than 2 minutes)
Description: 
I've found that when you're waiting in a queue, and has the announce
options configured, Asterisk only reports the ammount of time after 2
minutes of waiting. That's kind of weird, I didn't understand why not to
say when you're waiting for just "1 minute". It becomes a little weird when
you set up the round seconds options in queues.conf and gets something like
"less than 2 minutes, 37 seconds".

I wrote this very simple patch that makes app_queue say all the minutes
and seconds possible, including the singular form for 1 minute or second.
I'm not a programmer at all, I just used some copy & paste and I've been
testing it in my lab in the last two days without problem. Could someone
please review it and tell me if it's plain wrong, nonsense or something?

I just don't know the procedure triggered when a patch "creates" a new
sound file. The patch did its job, fixed a problem of mine :-P
====================================================================== 

---------------------------------------------------------------------- 
 caio1982 - 12-21-07 20:57  
---------------------------------------------------------------------- 
Keeping my own house cleaned, I uploaded a new patch that finish my initial
idea and even solves a bug introduced after this bug was opened:

- Completely removes the "lessthan 2 minutes" thing, as it's much worse
than changing it.

For example: VERBOSE[28314] logger.c:     -- Hold time for 555 is 1
minutes 26 seconds
expands to "less than two minutes twenty six seconds" *that* is very
weird. It simply should be "one minute twenty six seconds".

- Add a queue-minute audio file to substitute the above lessthan, so it
will indeed say correct hold times less than 2 minutes. One audio file out,
one audio file in, no big deal I think.

- Removes the option to round hold times == 1 as it introduces a bug where
you could possibly hear something like "3 minutes 1 seconds", plural, but
Asterisk does not provide this sound nor will (as far as I understood).
This was introduced on revision 64263, after this bug was opened.

This patch I just uploaded solves that. Corydon already said that is
stupid to say "1 second" as it's too specific and I wholly agree :-)

For the sake of documentation, I tested it and it really happens on
trunk:

   -- <SIP/111-01843000> Playing 'queue-thereare.gsm' (language 'en')
   -- <SIP/111-01843000> Playing 'digits/4.gsm' (language 'en')
   -- <SIP/111-01843000> Playing 'queue-callswaiting.gsm' (language 'en')
   -- Hold time for 555 is 2 minutes 1 seconds
   -- <SIP/111-01843000> Playing 'queue-holdtime.gsm' (language 'en')
   -- <SIP/111-01843000> Playing 'digits/2.gsm' (language 'en')
   -- <SIP/111-01843000> Playing 'queue-minutes.gsm' (language 'en')
   -- <SIP/111-01843000> Playing 'digits/1.gsm' (language 'en')
   -- <SIP/111-01843000> Playing 'queue-seconds.gsm' (language 'en')
   -- Told SIP/111-01843000 in 555 their queue position (which was 4)
   -- <SIP/111-01843000> Playing 'queue-thankyou.gsm' (language 'en')

Any objections?

PS: please, can someone update the bug's description to trunk, revision
94593? 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
12-21-07 20:57  caio1982       Note Added: 0075828                          
======================================================================