[asterisk-bugs] [Asterisk 0011544]: [patch] Check the value of the 'penalty' parameter for the AMI action 'QueuePenalty'

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11544 
====================================================================== 
Reported By:                Laureano
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11544
Category:                   Applications/app_queue
Reproducibility:            N/A
Severity:                   trivial
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 92855 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             12-13-2007 17:24 CST
Last Modified:              12-13-2007 19:32 CST
====================================================================== 
Summary:                    [patch] Check the value of the 'penalty' parameter
for the AMI action 'QueuePenalty'
Description: 
This patch handles the case where the penalty parameter for a queue member
received via the manager in a 'QueuePenalty' action is negative. If a
negative value is submitted for a member penalty, this is reject with an
error.

Disclaimer on file.
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 12-13-07 19:32  
---------------------------------------------------------------------- 
This is a good idea, but I think a better execution of the patch would be
to put the check for a negative penalty into the set_member_penalty
function. That way all methods of setting the member penalty will undergo
the same check. I realize this means removing existing checks from the CLI
command and dialplan function which do the same thing, but I think it's
always a good idea to avoid duplication of code when possible. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
12-13-07 19:32  putnopvut      Note Added: 0075375                          
======================================================================