[asterisk-bugs] [Asterisk 0011235]: silence threshold put to configuration

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11235 
====================================================================== 
Reported By:                philipps
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11235
Category:                   Applications/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.13  
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 89245 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-13-2007 11:45 CST
Last Modified:              12-07-2007 15:24 CST
====================================================================== 
Summary:                    silence threshold put to configuration
Description: 
Hi,
Below is the patch to get silence threshold from /etc/asterisk/dsp.conf
file instead of having it hardcoded. It is assumed, that dsp.conf has the
following contents:

[default]
silencethreshold=256

====================================================================== 

---------------------------------------------------------------------- 
 qwell - 12-07-07 15:24  
---------------------------------------------------------------------- 
There are some major coding guidelines violations in this patch -
specifically with spacing.  Please review that, and update the patch with
tabs rather than spaces, where appropriate.

Also, I'm seeing many places where silence threshold was 128, and we're
now setting the default to 256.  I'm not really sure what to do here - we
may just have to choose one or the other.

Rather than creating a new config file with only one option, it would
probably make more sense to find another config in which this option would
fit.  That config would likely be asterisk.conf. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
12-07-07 15:24  qwell          Note Added: 0075066                          
======================================================================