[asterisk-bugs] [Asterisk 0010540]: timeout value should accept floating point numbers

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10540 
====================================================================== 
Reported By:                spendergrass
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   10540
Category:                   Functions/func_timeout
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 89276 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-23-2007 13:27 CDT
Last Modified:              12-06-2007 10:47 CST
====================================================================== 
Summary:                    timeout value should accept floating point numbers
Description: 
Example, setting digit timeout value to 1.5 seconds should be accepted. 
Currently, it rounds down to nearest whole number.
====================================================================== 

---------------------------------------------------------------------- 
 cabal95 - 12-06-07 10:47  
---------------------------------------------------------------------- 
In pbx.h, the patch changes dtimeout and rtimeout to *ms, but the comment
still says it is the time in seconds.

main/app.c: ast_app_dtget(), the patch (it was incorrect before too)
incorrectly calls ast_waitfordigit() with seconds while it expects
milliseconds, why nobody has ever noticed this problem before I don't
know.

main/pbx.c: collect_digits() is now receiving ms in waittime (as it
should), but still multiplying by 1000 before calling ast_waitfordigit().

I'll have to do some digging to see if I can see why it is dropping calls
immediately. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
12-06-07 10:47  cabal95        Note Added: 0074923                          
======================================================================