[asterisk-bugs] [Asterisk 0009736]: [patch] "fixing" the saying of queue holdtime (for less than 2 minutes)

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=9736 
====================================================================== 
Reported By:                caio1982
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   9736
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 64186 
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             05-15-2007 21:38 CDT
Last Modified:              08-27-2007 17:29 CDT
====================================================================== 
Summary:                    [patch] "fixing" the saying of queue holdtime (for
less than 2 minutes)
Description: 
I've found that when you're waiting in a queue, and has the announce
options configured, Asterisk only reports the ammount of time after 2
minutes of waiting. That's kind of weird, I didn't understand why not to
say when you're waiting for just "1 minute". It becomes a little weird when
you set up the round seconds options in queues.conf and gets something like
"less than 2 minutes, 37 seconds".

I wrote this very simple patch that makes app_queue say all the minutes
and seconds possible, including the singular form for 1 minute or second.
I'm not a programmer at all, I just used some copy & paste and I've been
testing it in my lab in the last two days without problem. Could someone
please review it and tell me if it's plain wrong, nonsense or something?

I just don't know the procedure triggered when a patch "creates" a new
sound file. The patch did its job, fixed a problem of mine :-P
====================================================================== 

---------------------------------------------------------------------- 
 Corydon76 - 08-27-07 17:29  
---------------------------------------------------------------------- 
We can obliviate the need for "minute" and "second", if you consider that
anything under two minutes can be stated in seconds, like "90 seconds".  1
"second" is not needed, either, because by the time you say "we estimate
that your call will be answered in", it's longer than 1 second.  So you'd
never hear such a prompt to completion (and even if you did, it would sound
VERY weird).

Even telling someone their call is likely to be answered in ten seconds
sounds weird, and we probably should not get any more exact than to the
nearest 30 second mark. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-27-07 17:29  Corydon76      Note Added: 0069528                          
======================================================================