[asterisk-bugs] [Asterisk 0010550]: SIP Notify on Snom phones causes Asterisk to stop responding (not crash)

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10550 
====================================================================== 
Reported By:                ramonpeek
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10550
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.11  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-24-2007 05:35 CDT
Last Modified:              08-27-2007 01:31 CDT
====================================================================== 
Summary:                    SIP Notify on Snom phones causes Asterisk to stop
responding (not crash)
Description: 
Due to the revisions 79902-79904 which removes the semi-column in SIP
NOTIFY messages asterisk will stop responding after a Snom phones is
rebooted or check-synced through the SIP-NOTIFY command. 

However Snom phones use the semi-column in their NOTIFY messages to reboot
or load configuration. (they can't do without!)

Please note that the default SIP Notify message defined in sip_notify.conf
still shows an escaped semi-column ;
   [snom-check-cfg]
   Event=>check-sync\;reboot=false
   Content-Length=>0

Not escaping the semi-column does not work, since the phone doesn't
receive teh correct NOTIFY message and this reboots.. instead of just
reloading it's configuration.

Simply reverting the revisions solves the problem..
But is that really the solution?
There must be a good reason for trying to remove that semi-column?

====================================================================== 

---------------------------------------------------------------------- 
 tbelder - 08-27-07 01:31  
---------------------------------------------------------------------- 
I don't think a backtrace is necessary because asterisk doesn’t crash. It
hangs. When I do a ‘ps -aux’ I see asterisk has a cpu load of 70-80%. 

When I change the following code in chan_sip.c (method: sip_notify)
    add_header(&req, var->name, ast_unescape_semicolon(var->value));
to 
    add_header(&req, var->name, var->value);

Asterisk will work properly, only the semicolon is still escaped (off
course).


I have take a look in the code of util.c for the method
‘ast_unescape_semicolon’ and should work properly. 

When you send a ‘snom-check-cfg’ it works, only immediately asterisk
hangs and gives a cpu load of 70-80%.

I hope this enough information.. If a backtrace is necessary I will upload
a backtrace. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-27-07 01:31  tbelder        Note Added: 0069447                          
======================================================================