[asterisk-bugs] [Asterisk 0010419]: MOH wierdness

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10419 
====================================================================== 
Reported By:                mustardman
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   10419
Category:                   PBX/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.10  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-09-2007 12:40 CDT
Last Modified:              08-25-2007 00:53 CDT
====================================================================== 
Summary:                    MOH wierdness
Description: 
CentOS 5 FreePBX 2.3 b2 Asterisk 1.4.10 Zaptel 1.4.4 

With Random Play disabled it always starts at the beginning of the first
song so random play seems like the logical choice. However, with random
play enabled it randomly starts one of the 3 (for example) songs but if I
take the call and then put them on hold again it often goes to the
beginning of the next song. But if I do it again it will stay on that
second song and progress through it as it should. 

The MOH always starting at the beginning of a song when a call is first
put on hold is also annoying but I guess that is just the way it is
designed. 

However, there is something else wierd going on 


====================================================================== 

---------------------------------------------------------------------- 
 jamesgolovich - 08-25-07 00:53  
---------------------------------------------------------------------- 
The attached patch (to SVN trunk though it should work on 1.4.x just fine)
fixes this and 2 other bugs.  

Extra bug http://bugs.digium.com/view.php?id=1 was not decreasing the inuse
counter unless the channel would
be deleted, so reversing the order of operations fixes that

Extra bug http://bugs.digium.com/view.php?id=2 was limiting the number of files
moh would use in order to
255 since state->pos and state->save_pos were unsigned chars 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-25-07 00:53  jamesgolovich  Note Added: 0069409                          
======================================================================