[asterisk-bugs] [Asterisk 0010550]: SIP Notify on Snom phones causes Asterisk to stop responding (not crash)

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10550 
====================================================================== 
Reported By:                ramonpeek
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10550
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.11  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-24-2007 05:35 CDT
Last Modified:              08-24-2007 07:26 CDT
====================================================================== 
Summary:                    SIP Notify on Snom phones causes Asterisk to stop
responding (not crash)
Description: 
Due to the revisions 79902-79904 which removes the semi-column in SIP
NOTIFY messages asterisk will stop responding after a Snom phones is
rebooted or check-synced through the SIP-NOTIFY command. 

However Snom phones use the semi-column in their NOTIFY messages to reboot
or load configuration. (they can't do without!)

Please note that the default SIP Notify message defined in sip_notify.conf
still shows an escaped semi-column ;
   [snom-check-cfg]
   Event=>check-sync\;reboot=false
   Content-Length=>0

Not escaping the semi-column does not work, since the phone doesn't
receive teh correct NOTIFY message and this reboots.. instead of just
reloading it's configuration.

Simply reverting the revisions solves the problem..
But is that really the solution?
There must be a good reason for trying to remove that semi-column?

====================================================================== 

---------------------------------------------------------------------- 
 ramonpeek - 08-24-07 07:26  
---------------------------------------------------------------------- 
Looked a bit deeper into the issue...
It looks like the fix made in 9938 is causing quite a bit of problems.
I also needed to revert the changes in config.c to make it work again..

However the "real" issue here is that the "ast_unescape_semicolon"
function works but after it has been called it seems to put Asterisk in a
loop a bit further down the code..
The first time it's run, everything looks fine.. and the the SIP-NOTIFY is
send correctly... but after that ..... BUMMER... :-(

When I remove the call to the "ast_unescape_semicolon" function the
problem seems to be solved... however we then send an invalid NOTIFY
message...
But asterisk doesn't crash..

Some further help is wanted.. 
Since I cannot seem to figure out where it is that Asterisk starts to
loop.

PS: 
My collegue Theo Belder will take over this issue.. 
Since I'm bound for a holiday in France ;-) 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-24-07 07:26  ramonpeek      Note Added: 0069362                          
======================================================================