[asterisk-bugs] [Asterisk 0010424]: Allow realtime members on non realtime queues/A member with priorty < 0 is logged out

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10424 
====================================================================== 
Reported By:                irroot
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   10424
Category:                   Applications/app_queue
Reproducibility:            N/A
Severity:                   trivial
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.10  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-10-2007 02:18 CDT
Last Modified:              08-21-2007 10:35 CDT
====================================================================== 
Summary:                    Allow realtime members on non realtime queues/A
member with priorty < 0 is logged out
Description: 

hi there some trivial patches extending on the recent changes (adding
update_realtime_members) it seems to make logic sence to allow realtime
agents on non realtime queues (ive been doing this for over a year
already).

ive also been setting the priorty field in SQL to a negitive value as
opposed to deleteing the agent to log them off and then back to there
existing value to log them on again.
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 08-21-07 10:35  
---------------------------------------------------------------------- 
There are a couple of problems with your patch.

1. The if(rtbid) is unnecessary. The while loop will take care of this.
2. There is a possibility for a crash. If the while loop finishes without
finding the field "id" then the if(!ast_strlen_zero(rtbid->value)) will
cause a segfault since rtbid will be NULL. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-21-07 10:35  putnopvut      Note Added: 0069177                          
======================================================================