[asterisk-bugs] [Asterisk 0010514]: [patch] misleading check for AUTH_UNKNOWN_DOMAIN

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10514 
====================================================================== 
Reported By:                casper
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10514
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 80129 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-21-2007 06:38 CDT
Last Modified:              08-21-2007 10:05 CDT
====================================================================== 
Summary:                    [patch] misleading check for AUTH_UNKNOWN_DOMAIN
Description: 
AUTH_UNKNOWN_DOMAIN case is handled earlier in the function code.
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 08-21-07 10:05  
---------------------------------------------------------------------- 
It looks like you're right.  Rather than setting res to AUTH_UNKNOWN_DOMAIN
and then continuing on, it returns.  Thus, is appears that res can never be
set to AUTH_UNKNOWN_DOMAIN right there.

However, I'm a bit hesitant to make that change - and it probably wouldn't
be appropriate to do in 1.4 (it doesn't actually fix anything - it just
makes the code clearer). 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-21-07 10:05  qwell          Note Added: 0069173                          
======================================================================