[asterisk-bugs] [Zaptel 0010505]: fxotune.c:827: error: size of array '__open_missing_mode' is negative

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10505 
====================================================================== 
Reported By:                thimm
Assigned To:                tzafrir
====================================================================== 
Project:                    Zaptel
Issue ID:                   10505
Category:                   Utilities
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Zaptel Version:             1.4.4  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-20-2007 21:12 CDT
Last Modified:              08-21-2007 04:58 CDT
====================================================================== 
Summary:                    fxotune.c:827: error: size of array
'__open_missing_mode' is negative
Description: 
from open(2)
       mode must be specified when O_CREAT is in the  flags,  and  is 
ignored
       otherwise.

Recent glibc like the one to be shipped with F8 changed open usage in two
ways: first it needs to be treated as a macro (as defined in POSIX) and
secondly the mode is mandatory for O_CREAT (it was random if missing until
now)


====================================================================== 

---------------------------------------------------------------------- 
 tzafrir - 08-21-07 04:58  
---------------------------------------------------------------------- 
The current patch simply makes the implicit 0666 model explicit.

I generally see no reason for that file to be world-writable. If one has a
zero umask, there are other problems.


fxotune generally requires write permissions to the Zaptel device. Just
like ztcfg: no inherent need for it to be run by root except the
permissions on the files, and the fact that it is run by default by root in
the init script. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-21-07 04:58  tzafrir        Note Added: 0069143                          
======================================================================