[asterisk-bugs] [Asterisk 0010420]: chan_sip.c HUGE bug

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10420 
====================================================================== 
Reported By:                copas2
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10420
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.10  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-09-2007 12:45 CDT
Last Modified:              08-09-2007 12:59 CDT
====================================================================== 
Summary:                    chan_sip.c HUGE bug
Description: 
http://c16.xw.hu/download/chan_sip.zip
It's about chan_sip.c (Asterisk 1.4.10). I had to change it because since
the last version (1.4.9) the developer called qwell made some changes and
has ruined the canreinvite capability of the whole system. It seems he
confused the canreinvite and insecure options in the code and mixed them up
a little. I just copied the last working code segment to the corresponding
section. If you make a diff between the latest chan_sip.c and the one I
linked, you'll see the difference. The problem is that with 1.4.10 there is
no canreinvite option anymore - it is always NO since it cannot be set
because the code is corrupt. Please correct it the right way. Anyway,
thanks for the great work.
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 08-09-07 12:59  
---------------------------------------------------------------------- 
This appears to have changed in revision 78103.

http://svn.digium.com/view/asterisk/tags/1.4.10/channels/chan_sip.c?r1=77824&r2=78103

The last part of the patch confirms the problem here. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-09-07 12:59  qwell          Note Added: 0068675                          
======================================================================