[asterisk-bugs] [Asterisk 0010320]: 1.4.9 changes to app_queue breaks 'joinempty=yes'

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10320 
====================================================================== 
Reported By:                jfitzgibbon
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10320
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.9  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-27-2007 07:04 CDT
Last Modified:              08-08-2007 09:18 CDT
====================================================================== 
Summary:                    1.4.9 changes to app_queue breaks 'joinempty=yes'
Description: 
1.4.9 introduced changes to app_queue that change the logic associated with
exiting the queue due to a timeout.

The 1.4.8 logic would only ever be executed if the 'n' option was passed
to Queue(), as designed.

The 1.4.9 logic can be executed in the absence of the 'n' option if the
queue is empty.  The net effect is that a queue configured as
'joinempty=yes' with no members in it cannot be enqueued to in 1.4.9 -
calls will immediately be kicked back to the dialplan.  Depending on how
the dialplan was built, this could result in calls being unceremoniously
hung up if there are no further steps in the extension that called Queue()
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 08-08-07 09:18  
---------------------------------------------------------------------- 
You'll notice in my latest commit that now noption is a boolean that is set
if the 'n' option is enabled, and the variable which keeps track of how
many calls to queue members have been attempted is called "tries." This
should clear up confusion in the code and get rid of any erroneous queue
exits for people not using the 'n' option.

Thank you very much, jfitzgibbon, for suggesting this. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-08-07 09:18  putnopvut      Note Added: 0068616                          
======================================================================